Changeset 27531

Timestamp:

Feb 7, 2023, 8:33:22 AM (18 months ago)

Author:

Freagarach

Message:

Don't error out on complex requirements without tooltip.

Since it is not nice to make the game unusable (citation needed) we'll emit a warning, which is less not nice.
Reported by: @Langbart

Differential revision: ​https://code.wildfiregames.com/D4930
Reviewed by: @Langbart
Fixes #6724

File:

• ps/trunk/binaries/data/mods/public/gui/common/tooltips.js (modified) (1 diff)

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

@@ -969 +969 @@
 
     // Simple requirements (one tech) can be translated on the fly.
-    if ("Techs" in requirements && !requirements.Techs._string.includes(" "))
+    if ("Techs" in requirements && !requirements.Techs._string.includes(" ") &&
+            requirements.Techs._string[0] != "!")
         return objectionFont(sprintf(translate("Requires %(technology)s"), {
             "technology": getEntityNames(GetTechnologyData(requirements.Techs._string, civ))
         }));
-    return objectionFont(translate(requirements.Tooltip));
+
+    // More complex ones need a tooltip.
+    if ("Tooltip" in requirements)
+        return objectionFont(translate(requirements.Tooltip));
+
+    warn("Complex requirements found, but no tooltip specified. More complex requirements can't be translated on the fly easily.")
+    return "";
 }