Changeset 27231

Timestamp:

Nov 18, 2022, 8:32:20 PM (20 months ago)

Author:

Vladislav Belov

Message:

Remove unused members of TaskManager::Impl missed in rP25656.

Patch By: phosit

Differential Revision: ​https://code.wildfiregames.com/D4826

Location:

ps/trunk/source/ps

Files:

• TaskManager.cpp (modified) (5 diffs)
• TaskManager.h (modified) (1 diff)

ps/trunk/source/ps/TaskManager.cpp

@@ -125 +125 @@
     friend class WorkerThread;
 public:
-    Impl(TaskManager& backref);
+    Impl(;
     ~Impl()
     {
@@ -150 +150 @@
     bool PopTask(std::function<void()>& taskOut);
 
-    // Back reference (keep this first).
-    TaskManager& m_TaskManager;
-
     std::atomic<bool> m_HasWork = false;
     std::atomic<bool> m_HasLowPriorityWork = false;
@@ -162 +159 @@
     // Ideally this would be a vector, since it does get iterated, but that requires movable types.
     std::deque<WorkerThread> m_Workers;
-
-    // Round-robin counter for GetWorker.
-    mutable size_t m_RoundRobinIdx = 0;
 };
 
@@ -172 +166 @@
 
 TaskManager::TaskManager(size_t numberOfWorkers)
-{
-    m = std::make_unique<Impl>(*this);
+    : m{std::make_unique<Impl>()}
+{
     numberOfWorkers = Clamp<size_t>(numberOfWorkers, MIN_WORKERS, MAX_WORKERS);
     m->SetupWorkers(numberOfWorkers);
@@ -179 +173 @@
 
 TaskManager::~TaskManager() = default;
-
-TaskManager::Impl::Impl(TaskManager& backref)
-    : m_TaskManager(backref)
-{
-}
 
 void TaskManager::Impl::SetupWorkers(size_t numberOfWorkers)

ps/trunk/source/ps/TaskManager.h

@@ -78 +78 @@
 
     class Impl;
-    std::unique_ptr<Impl> m;
+    std::unique_ptr<Impl> m;
 };
 } // namespace Threading