Changeset 25075

Timestamp:

Mar 18, 2021, 10:01:19 AM (3 years ago)

Author:

wraitii

Message:

Fix infinite loop in healing & potential one elsewhere.

HEAL can infinite loop: if the HEAL.APPROACHING:MoveTo call fails, the unit will fallback to FINDINGNEWTARGET, which looks for new targets to heal, which can loop around.
In #6106, the cause was that the target was not visible despite the order being given (presumably a rangemanager/los incompatibility issue).
When MoveTo() fail, orders usually call FinishOrder as that's irrecoverable.

Further, GATHERING/COLLECTINGTREASURE also did not FinishOrder - there, we do want to consider new resources if the target is e.g. unreachable, so add an explicit check for AbleToMove.

Reported by: moiman

Reviewed By: Freagarach

Fixes #6106

Differential Revision: ​https://code.wildfiregames.com/D3689

File:

• ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js (modified) (3 diffs)

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

@@ -2368 +2368 @@
                     this.gatheringTarget = this.order.data.target;  // temporary, deleted in "leave".
 
+
+
+
+
+
+
+
+
                     let cmpSupply = Engine.QueryInterface(this.gatheringTarget, IID_ResourceSupply);
                     let cmpMirage = Engine.QueryInterface(this.gatheringTarget, IID_Mirage);
@@ -2691 +2699 @@
                     if (!this.MoveTo(this.order.data, IID_Heal))
                     {
-                        this.SetNextState("FINDINGNEWTARGET");
+                        this.);
                         return true;
                     }
@@ -2890 +2898 @@
             "APPROACHING": {
                 "enter": function() {
+
+
+
+
+
+
+
                     if (!this.MoveToTargetRange(this.order.data.target, IID_TreasureCollecter))
                     {