Principal software engineer at WMF
User Details
- User Since
- Nov 6 2014, 11:05 PM (506 w, 6 d)
- Availability
- Available
- IRC Nick
- jdlrobson
- LDAP User
- Unknown
- MediaWiki User
- Jdlrobson [ Global Accounts ]
Today
@bwang I'm pretty sure this is the Wikiloves Earth banner - see latest video on https://grafana.wikimedia.org/d/IvAfnmLMk/synthetic-testing-page-drilldown?orgId=1&var-base=sitespeed_io&var-path=emulatedMobile&var-testtype=webpagereplay&var-group=en_m_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=chrome&var-connectivity=0&var-function=median&var-s3path=https:%2F%2Fwikimedia.sitespeed.io
Thanks for the feedback and refinement @Izno, I appreciate it! Updated the description to take all of this into account.
Yesterday
Categories are not displayed on mobile for anons and the associated config has been intentionally disabled since 2015 via https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/438b5e888068032ac1bcccce118e3cb05a0228ac/includes/MobileFrontendHooks.php#1150 to reduce code bloat (T121791). They are only available to users using the advanced mode.
@Izno we recently changed the implementation proposal to add ">" between mw-parser-output and figure to avoid it applying to templates. I think that is preferable to a selector that applies to all figure elements having observed how this is working in production and the bug reports we've been getting.
Tue, Jul 23
Per T335379 we didn't do this.
This extension is maintained by Community Tech according to https://www.mediawiki.org/wiki/Developers/Maintainers
Mon, Jul 22
Fri, Jul 19
@ovasileva We should review the usage of the button to get a sense of the volume here. Perhaps if it is low we could reconsider the behaviour?
i'm facing issues while committing. Is it appropriate to ask it here?
You will have more success troubleshooting in our IRC channels or Discord server https://en.wikipedia.org/wiki/Wikipedia:Discord but yes you can describe the problem and I can try and direct you to some helpful information.
Thanks for the input! Definitely requires more thought.
I don't see any reason why we shouldn't do this. @ovasileva ?
Okay I propose we attempt a CSS only solution first.
I've proposed https://phabricator.wikimedia.org/T359002 - let's estimate that ticket and if we get a successful estimation we can move this to sign off.
Can you provide some QA steps on this one? Thanks in advance!
For anonymous users clicking the button logs an event. It intentionally doesnt open the talk page for now. Please see requirements on T367871
Replication:
- enable vector 2022 skin
- go to https://www.wikidata.org/wiki/Special:Preferences#mw-prefsection-betafeatures ans enable accessibility for reading
- go to any page and select dark mode from the very prominent right sidebar
Thu, Jul 18
All quite on the wikis so far but I'll leave this open another day in case people who missed the many communications wake up tomorrow to gadgets not working.
I'm chatting with @Vgutierrez right now who has been able to reproduce the issue but we don't have answers. Sorry for the confusion around parser cache. It's not related.
This should be addressed now.
We can ignore the NewPP limit report comment for now!
I'm seeing HTML older than 24hrs as we speak.
@CCiufo-WMF never=0 always=1. Note this data is just for English Wikipedia, the local exceptions indicate users have global preferences set where the value is different. e.g. underline-local-exception 0 means someone globally enabled "always" for all wikis except English which they set to "never".
Here's a replication URL:
https://www.wikidata.org/wiki/Q36500248?vectornightmode=1&useskin=vector-2022
Hi we just discovered a train blocker that impacts dark mode. We're creating a bug and working on a patch now but please don't roll the train forward until we've given the green light!
Open questions:
- Does Vector manage multiple overlays or do we need to manage this ourselves?
- Is the intention to run both banners at the same time in different places?
- Will any styling modifications be required for Vector 2022?
- Do any modifications need to be made to the campaign e.g. around skin or are all these changes only in the Minerva banner?
- Does it make sense to fork the code in Minerva and copy to Vector 2022 or to load the Minerva code in Vector 2022?
- Will this need a backport?
The request here would be to not disable the font size setting on action=submit. URLs which would be a site configuration change.
@CCiufo-WMF usage as requested:
@GMikesell-WMF I can verify this. The URL matches no results, so that's what we're verifying here.
Wed, Jul 17
I believe Bernard is investigating. Please unassign if not!
Sorry about that! I am happy to abandon my patch if you push one. I would just like to get this one fixed! Feel free to review my patch if you are aware of a better way to fix the test.