This went great, fantastic. I was wondering if the same team can adopt https://gerrit.wikimedia.org/r/q/project:css-sanitizer+status:open also.

So now this can be merged https://gerrit.wikimedia.org/r/c/mediawiki/libs/php-cssjanus/+/1052813 also I think

It is fixed now the far I checked

Recently I've made the tool able to not reject images that just had size improvement with https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-ImageAnnotator.js&diff=prev&oldid=887093691 and noow I see this issue, I'm not sure how that's related to my changes or how I can share the logic.

Also purposed as a Community Wishlist https://meta.wikimedia.org/wiki/Community_Wishlist/Wishes/Hosting_of_free_fonts_in_Commons

@Nikki Thanks for the very helpful context, based on that I've created a RfC to see what Commons community also think about it. https://commons.wikimedia.org/wiki/Commons:Requests_for_comment/Hosting_of_free_fonts_in_Commons

That would be fantastic indeed.

It seems everything is set now, we now have ICU 67.1 in 2024 and this was supposed to be fixed in ICU 63 in 2020...

Interestingly we have already have good number of {margin,padding}-{block,inline} uses even without fallback mostly in ContentTranslation extension,

This is where it's checkbox is on https://appstoreconnect.apple.com

Fix uploaded at https://github.com/wikimedia/apps-android-wikipedia/pull/4816

@matmarex I didn't know, it was surprising, thanks, uploaded a patch to use that then https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1054064 😊

If one first uses mw.language.convertNumber before passing to mw.msg like here, https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/a861b0256ae4999b6f5998fd3e40c44ee5deaf94/modules/tools/mw.cx.tools.IssueTrackingTool.js#L287-L292 will a plural message like {{PLURAL:$1|$1 warning|$1 warnings}} parse and analysis native digits like ۱ ۲ ۳ just like 1 2 3? The JS counterpart should've followed the same pattern as PHP one

I've uploaded a patch to support inline-start and inline-end and it works locally but it needs some tests and parsoid to be made compatible, but actually I like to suggest use of 'start' and 'end', without 'inline' before too late,

Today I came across this site https://longform.asmartbear.com/color-wheels/ that not only has a better background and text color for its dark mode but it has dimmed all the pictures in the dark mode using,

.longform figure.figure:not(.darkImage, .dark-invert, .no-dark-treatment) picture.dark {
    filter:brightness(.6)saturate(80%)drop-shadow(0 0 1px rgba(255, 255, 255, .811765))
}

Consulting @Ladsgroup I've put the following on Persian Wikipedia,

This made me realise. Do users actually expect the left side is Next action and the right side is Previous ? Are we the exception to everything else or not ?

And I've fixed it temporarily for Persian Wikipedia https://fa.wikipedia.org/w/index.php?title=مدیاویکی%3ACommon.css&diff=39856756&oldid=39784393 so you can see the issue now only in the safemode https://fa.wikipedia.org/wiki/حافظیه?uselang=fa&safemode=1#/media/پرونده:HAFEZIA_TOMB_ROOF_Ariafar_Khosravi.jpg

This is in the CSS ?debug=1 output of the page,

This change https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/commit/2a8b140ed363255e4d56a39cf5a658bf2e98d4f1 associated with this issue has caused multimediaviewer icons to have https://commons.wikimedia.org/wiki/File:Screenshot_Icons.png incorrect direction in RTL wikis,

Here is an example of nested more than two layers direction which isn't handled by the current approach,

The dark mode really is horrible and not usable.

Thanks to your pointer the back port to PHP is already done https://gerrit.wikimedia.org/r/c/mediawiki/libs/php-cssjanus/+/1052813 and it uses the unreleased tests of node-cssjanus.

@Jdforrester-WMF Would you please help 'just' on the first part of what Krinkle said, releasing a new version of node-cssjanus? Thank you so much!

A new task as you suggested, T369553

Let's go with the first one first, how the new version can be published, last release of node-cssjanus wasn't is in Gerrit and css-sanitizer's release https://gerrit.wikimedia.org/r/c/css-sanitizer/+/1021556 doesn't give me a clue how it can be done.

Just to note about the change above, I wanted to add a guarantee to CSS Janus that it won't ever touch CSS Logical properties and values and it turned out php-cssjanus which is in use in MediaWiki fetches the tests from node-cssjanus https://github.com/wikimedia/node-cssjanus/blob/master/test/data.json so went to add the tests there first in node-cssjanus, and it went well but the moment I wanted to update the tests in php-cssjanus it turned out node-cssjanus and php-cssjanus have become out of sync since T333276 but CSS Logical related tests already pass unlike calc related tests so hopefully when there will be any major development in php-cssjanus it first can get synced again with node-cssjanus so to have the tests in.

It apparently will need a good amount of work https://github.com/wikimedia/node-cssjanus/pull/36/commits/827718c3566aa11c83912a8c672f52515d36c10a

Just to note this php-cssjanus is out of sync with this change, guess this should be reopened, let's see what can be done.

[..] Especially the fact that Safari only started fully supporting in Safari 15, is problematic, [..]

Thanks for reporting this. For future reference, please use the feature request form (linked from the top of the task creation page) to create feature requests, and fill in all the sections in the template. Thanks.

And here is a very initial and very basic MediaWiki extension to use Chemistoid, https://github.com/ebraminio/InChI

CDK https://github.com/cdk/cdk supports different formats so I've deployed it on tools, see https://chemistoid.toolforge.org/InChI=1S/C6H6/c1-2-4-6-5-3-1 and it's source https://github.com/ebraminio/Chemistoid I'm planning to create a PoC MediaWiki extension to understand with something like this <InChI>1S/C6H6/c1-2-4-6-5-3-1</InChI> syntax, similar to math syntax and Interactivity can be provided later by JSMol, if is anyone interested on this work.

I don't insist on it much though I have my original opinion about it so let's close. Thanks 😊

That works also, I didn't know, but border-color: var(--border-subtle-color, #c8ccd1); doesn't.

I suggest using the background success color for these, as @Ebrahim did in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/1050668

We have 1,362,174 uses of InChI according to Wikidata, https://www.wikidata.org/wiki/Special:WhatLinksHere/Property:P234

In T368637#9937285, @Tacsipacsi wrote:

I think specifying border-top-color, border-right-color, border-bottom-color and border-left-color, while looks ugly, should work.

Sorry for the noise, the patch wasn't related to this issue.

• https://gerrit.wikimedia.org/r/1050724 implements all of the introduced properties in CSS Logical. They are implemented by the browser for a considerable time as far as I can see.
• https://gerrit.wikimedia.org/r/1050707 implements new values of float.
• start and end for text-align is already available.
• recto and verso for page-break also is already available.
• These https://drafts.csswg.org/css-logical/#logical-shorthand-keyword aren't finalized by the draft and not implemented by the browsers as far as I can see.

I'm trying to help a bit here, will update this comment

I wanted to make https://commons.wikimedia.org/wiki/Module:Diff compatible with dark mode but knowing var are allowed by background-color but not border-color I only fixed background-color ones https://commons.wikimedia.org/w/index.php?title=Module%3ADiff%2Fstyles.css&diff=889925503&oldid=360425282 and am thinking about use of inline styles for unsupported ones.

Ah I missed that but are you sure they are readable as it doesn't seem to be in Persian Wikipedia at least,

@Ebrahim would you be interested in helping me with this one too?