User Details
- User Since
- Aug 5 2019, 7:51 PM (259 w, 2 d)
- Availability
- Available
- LDAP User
- Anne Tomasevich
- MediaWiki User
- ATomasevich (WMF) [ Global Accounts ]
Today
Yesterday
@Catrope do you remember why you implemented the initialPlacement fallback strategy way back in this patch? I'm trying to figure out if it's needed - it's messing up the MenuButton behavior, and doesn't seem necessary for other components IMO but I'm not sure.
I submitted a patch with a new demo that reproduces this behavior in the Sandbox so you don't have to spin up MPIC to see the bug. There are 2 issues here:
Tue, Jul 23
Mon, Jul 22
@CCiufo-WMF yes, and I plan to talk to the engineering team about this tomorrow during our synchronous meeting. We'll want to think through the potential for regressions and a testing plan, as you said.
This is a flexbox thing, and is not specific to InputBox - it could happen anywhere a button is used in a flex layout. It's also not related to the text truncation within the Button component.
Wed, Jul 3
Tue, Jul 2
Mon, Jul 1
Sat, Jun 29
@Catrope sorry, I missed up the two tasks!
Thu, Jun 27
Wed, Jun 26
Sorry @lwatson, I forgot to claim this and move it to "code review" when I opened the patch!@
Tue, Jun 25
Initially thought 2, but bumped to 3 in case we want to include:
- only adding necessary messages when code splitting is used (worth it? maybe not)
- testing
Tagging you all since this is a potential breaking change for Codex 2.0
Specific to the indication of scroll part:
Jun 25 2024
Jun 24 2024
Jun 21 2024
Jun 18 2024
Jun 17 2024
Great, thanks @bmartinezcalvo and @DTorsani-WMF! I'll update my patch to:
- Keep the menu open on select
- Add the check icons
- Add deselection by re-clicking an option