Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: DuckStudio.GitHubLabelsManager version v1.1 #161398

Merged
merged 14 commits into from
Jul 12, 2024
Merged

New package: DuckStudio.GitHubLabelsManager version v1.1 #161398

merged 14 commits into from
Jul 12, 2024

Conversation

DuckDuckStudio
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio commented Jul 3, 2024 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
PS> winget validate --manifest manifests\d\DuckStudio\GitHubLabelsManager\1.1
清单验证成功。
  • Have you tested your manifest locally with winget install --manifest <path>?

Thanks to aisgbnok for the help.
DuckDuckStudio/GitHub-Labels-Manager#3

Note: <path> is the directory's name containing the manifest you're submitting.

Packing log: packing.log

Microsoft Reviewers: Open in CodeFlow
@DuckDuckStudio DuckDuckStudio changed the title Duck studio.glm.version.1.1 Jul 3, 2024
@DuckDuckStudio DuckDuckStudio changed the title [Need help] Add DuckStudio.GitHubLabelsManager v1.1 Jul 3, 2024
@fjwxzde fjwxzde mentioned this pull request Jul 3, 2024
Merged
@DuckDuckStudio DuckDuckStudio mentioned this pull request Jul 4, 2024
Merged
7 tasks
aisgbnok
aisgbnok suggested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@aisgbnok aisgbnok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need help.
I want to submit this package, but this package has installers in multiple languages, how do I write the manifest?

You can add back the en-US file but with some modifications:

You choose a defaultLocale which seems to be zh-CN for this package. And then any additional locales use the locale type manifest file.

I only have experience working with en-US as defaultLocale, but I hope this helps.
manifests/d/DuckStudio/GitHubLabelsManager/1.1/DuckStudio.GitHubLabelsManager.locale.en-US.yaml Outdated Show resolved Hide resolved
manifests/d/DuckStudio/GitHubLabelsManager/1.1/DuckStudio.GitHubLabelsManager.locale.en-US.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 4, 2024
@aisgbnok
Copy link
Contributor

aisgbnok commented Jul 4, 2024 •
edited
Loading

Example:

DuckStudio.GitHubLabelsManager.installer.yaml 
# Created using wingetcreate 1.6.1.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json

PackageIdentifier: DuckStudio.GitHubLabelsManager
PackageVersion: "1.1"
InstallerType: inno
Scope: machine
InstallModes:
- interactive
- silent
- silentWithProgress
InstallerSwitches:
  Silent: /verysilent /suppressmsgboxes
  SilentWithProgress: /verysilent
UpgradeBehavior: install
Commands:
- glm
Protocols:
- http
- https
ReleaseDate: 2024-07-04
AppsAndFeaturesEntries:
- DisplayVersion: 'v1.1'
ElevationRequirement: elevatesSelf
Installers:
- InstallerLocale: zh-CN
  Architecture: x86
  InstallerUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/releases/download/v1.1/GitHub_Labels_Manager_Setup_v1.1.exe
  InstallerSha256: BE85E341C4284514C72778C3F94EA651DE82E0237BCCFCFE60FAA43EEEB7F0EB
- InstallerLocale: zh-CN
  Architecture: x64
  InstallerUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/releases/download/v1.1/GitHub_Labels_Manager_Setup_v1.1.exe
  InstallerSha256: BE85E341C4284514C72778C3F94EA651DE82E0237BCCFCFE60FAA43EEEB7F0EB
- InstallerLocale: en-US
  Architecture: x86
  InstallerUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/releases/download/v1.1/GitHub_Labels_Manager_Setup_v1.1_EN.exe
  InstallerSha256: 839D0B64CEA9A8E32FB0117900649553FCF64C384A3C7BAF2A2AF07E5220C43A
- InstallerLocale: en-US
  Architecture: x64
  InstallerUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/releases/download/v1.1/GitHub_Labels_Manager_Setup_v1.1_EN.exe
  InstallerSha256: 839D0B64CEA9A8E32FB0117900649553FCF64C384A3C7BAF2A2AF07E5220C43A
ManifestType: installer
ManifestVersion: 1.6.0
DuckStudio.GitHubLabelsManager.locale.zh-CN.yaml 
# Created using wingetcreate 1.6.1.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json

PackageIdentifier: DuckStudio.GitHubLabelsManager
PackageVersion: "1.1"
PackageLocale: zh-CN
Publisher: DuckStudio
PublisherUrl: https://duckduckstudio.github.io/yazicbs.github.io/
PublisherSupportUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/issues
Author: 鸭鸭「カモ」
PackageName: GitHub Labels Manager
PackageUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager
License: GPL-3.0
LicenseUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/blob/main/LICENSE
Copyright: Copyright (c) DuckStudio 鸭鸭「カモ」
ShortDescription: GitHub仓库标签管理工具
Description: 自动帮你复制仓库标签、获取仓库标签、清空已有标签的工具
Moniker: glm
Tags:
- devtools
- github
- github-labels
- labels
ReleaseNotes: 初始功能实现
ReleaseNotesUrl: https://github.com/DuckDuckStudio/Chinese_git/releases/tag/v1.1
ManifestType: defaultLocale
ManifestVersion: 1.6.0
DuckStudio.GitHubLabelsManager.locale.en-US.yaml 
# Created using wingetcreate 1.6.1.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.locale.1.6.0.schema.json

PackageIdentifier: DuckStudio.GitHubLabelsManager
PackageVersion: "1.1"
PackageLocale: en-US
Publisher: DuckStudio
PublisherUrl: https://duckduckstudio.github.io/yazicbs.github.io/
PublisherSupportUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/issues
Author: 鸭鸭「カモ」
PackageName: GitHub Labels Manager
PackageUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager
License: GPL-3.0
LicenseUrl: https://github.com/DuckDuckStudio/GitHub-Labels-Manager/blob/main/LICENSE
Copyright: Copyright (c) DuckStudio 鸭鸭「カモ」
ShortDescription: A GitHub Labels Manager
Description: Tools that automatically help you copy repo labels, get repo labels, and empty existing labels.
Tags:
- devtools
- github
- github-labels
- labels
ReleaseNotes: Initial function implementation.
ReleaseNotesUrl: https://github.com/DuckDuckStudio/Chinese_git/releases/tag/v1.1
ManifestType: locale
ManifestVersion: 1.6.0
DuckStudio.GitHubLabelsManager.yaml 
# Created using wingetcreate 1.6.1.0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json

PackageIdentifier: DuckStudio.GitHubLabelsManager
PackageVersion: "1.1"
DefaultLocale: zh-CN
ManifestType: version
ManifestVersion: 1.6.0
@aisgbnok aisgbnok mentioned this pull request Jul 4, 2024
Closed
@aisgbnok
Copy link
Contributor

aisgbnok commented Jul 4, 2024

Manifest Warning: Unknown field. [Moniker]

Moniker is only allowed in ManifestType: defaultLocale.
@DuckDuckStudio
🎁 Application suggestion
435f930 
清单验证成功，但出现警告。
Manifest Warning: Unknown field. [Moniker]
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Jul 4, 2024
DuckDuckStudio added a commit to DuckDuckStudio/GitHub-Labels-Manager that referenced this pull request Jul 4, 2024
@DuckDuckStudio
fix: Fix route issue
f6c6106 
tag v1.1
Need update winget manifest

Issue Installer setting incorrect directory for Windows Environment Variables PATH #3
winget microsoft/winget-pkgs#161398
@DuckDuckStudio DuckDuckStudio removed their assignment Jul 4, 2024
@DuckDuckStudio DuckDuckStudio marked this pull request as draft July 4, 2024 14:07
@DuckDuckStudio
Copy link
Contributor Author

Edit: DuckDuckStudio/GitHub-Labels-Manager#4
@DuckDuckStudio DuckDuckStudio marked this pull request as ready for review July 4, 2024 15:03
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Changes-Requested Changes Requested New-Package labels Jul 12, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jul 12, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 886.)
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 12, 2024
@stephengillie stephengillie merged commit 28eee5f into microsoft:master Jul 12, 2024
8 checks passed
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello DuckDuckStudio,
Validation has completed.

Template: msftbot/validationCompleted
1 similar comment
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello DuckDuckStudio,
Validation has completed.

Template: msftbot/validationCompleted
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.
@DuckDuckStudio DuckDuckStudio deleted the DuckStudio.GLM.version.1.1 branch July 12, 2024 20:19
@DuckDuckStudio DuckDuckStudio mentioned this pull request Jul 17, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
8 participants
@DuckDuckStudio @aisgbnok @stephengillie @hackean-msft @Trenly @wingetbot @fjwxzde @Luna-Grace