Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Package: Added vencord 1.9.3 #160797

Closed
wants to merge 4 commits into from
Closed

New Package: Added vencord 1.9.3 #160797

wants to merge 4 commits into from

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Jun 30, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves: #160788

Microsoft Reviewers: Open in CodeFlow
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 30, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Jun 30, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jun 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 30, 2024
@Trenly
Copy link
Contributor

Trenly commented Jul 1, 2024 

INFO  Patching C:\Users\WDAGUtilityAccount\AppData\Local\Discord...
ERROR Cannot patch because Discord's files are used by a different process.
Make sure you close Discord before trying to patch!
❌ Failed!
@vikingnope
Copy link
Contributor Author

@Trenly, is there a way to force Discord to be closed?
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 1, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 886.)
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

Hi @vikingnope,

Is there an insatller switch needed to skip this message and complete the install silently?

Related - there are 2 empty lines at the top of each manifest file. It looks as though the comment block (usually listing package manager authoring tool and schema) were removed, but the line break wasn't. Is this intentional?
@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 1, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Jul 1, 2024
@vikingnope
Copy link
Contributor Author

I don't believe I have found a way to skip the completed screen.
@vikingnope
Copy link
Contributor Author

@Vendicated, is there a way to skip the success patched screen?
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jul 1, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 886.)
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 7, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @vikingnope,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
4 participants
@vikingnope @wingetbot @Trenly @stephengillie