Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanManifest_(timestamp).json file collision #495

Open
AArnott opened this issue Feb 6, 2024 · 1 comment
Open

ScanManifest_(timestamp).json file collision #495

AArnott opened this issue Feb 6, 2024 · 1 comment
Labels
help wanted Extra attention is needed tabled We like this idea, but we are not going to action on it in the moment

Comments

@AArnott
Copy link
Member

AArnott commented Feb 6, 2024

The Microsoft.ManifestTool tool generates a temporary file in a shared directory, with apparently nothing but a timestamp to make it unique. But when msbuild builds a multi-targeting project, both projects may invoke the tool concurrently, and the timestamp can actually collide:

image

This breaks the build.
Please add more entropy to the filename, or allow a command line switch to specify a directory that is safely isolated from concurrent builds, and I'll happily provide that location.

@jlperkins jlperkins added help wanted Extra attention is needed tabled We like this idea, but we are not going to action on it in the moment labels Feb 8, 2024
@pownkel
Copy link
Contributor

pownkel commented Feb 15, 2024

@AArnott The name and path of that file are determined by the Component Detection library, and can be changed by passing "--ManifestFile <new file path>" to AdditionalComponentDetectorArgs (the -cd flag if running on command-line).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed tabled We like this idea, but we are not going to action on it in the moment
3 participants