Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ILogger<T> from Microsoft.Extensions.Logging instead of ILogger from Serilog #284

Open
JamieMagee opened this issue Jun 28, 2023 · 2 comments
Assignees
Labels
tabled We like this idea, but we are not going to action on it in the moment

Comments

@JamieMagee
Copy link
Member

The SBOM tool uses Serilog's ILogger interface directly. Unfortunately, Component Detection expects the ILogger<T> interface from Microsoft.Extensions.Logging and uses the Serilog.Extensions.Logging package to provide an implementation.

In our research, using the Microsoft.Extensions.Logging logging API, and plugging in different logging frameworks (like Serilog) was the recommended approach.

@edgarrs edgarrs added z-aa-triaged (Deprecated label) This issue has been triaged by AA z-P2 (Deprecated label) Priority 2 labels Jul 10, 2023
@ryanbrandenburg
Copy link
Contributor

We think this is already fixed, @sebasgomez238 the work item is to double-check that assumption.

@JamieMagee
Copy link
Member Author

JamieMagee commented Jul 31, 2023

I think that some of this work was completed in #292. However, there are still a lot of use cases of ILogger directly from Serilog, instead of ILogger<T> from Microsoft.Extensions.Logging.

EDIT: Actually, it depends. The work was completed to upgrade Component Detection and all the logger references there. Actually working on the rest of the code base isn't required, but using two different logger interfaces is slightly confusing.

@jalkire jalkire added the tabled We like this idea, but we are not going to action on it in the moment label Feb 29, 2024
@jlperkins jlperkins removed z-aa-triaged (Deprecated label) This issue has been triaged by AA z-P2 (Deprecated label) Priority 2 labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabled We like this idea, but we are not going to action on it in the moment
6 participants