Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Allow using other database types for teachability #3066

Open
tyler-suard-parker opened this issue Jul 2, 2024 · 16 comments
Labels
enhancement New feature or request

Comments

@tyler-suard-parker
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, teachable agents only use chromadb for saving and loading memos. It would be nice to change this, as we want to scale up the program. We would like to use MongoDB for CosmosDB as our backend, so we can have more memories for more users.

Describe the solution you'd like

It would be nice to be able to easily switch between database types for storing memos from teachable agents.

Additional context

No response

@tyler-suard-parker tyler-suard-parker added the enhancement New feature or request label Jul 2, 2024
@rickyloynd-microsoft
Copy link
Contributor

Sounds good. Would you like to implement this?

@tyler-suard-parker
Copy link
Contributor Author

tyler-suard-parker commented Jul 2, 2024

@rickyloynd-microsoft In the past, I made a new feature for autogen and I created a PR. I built the feature and tests, and it worked, I felt like that should have been enough. However, I was asked to do a bunch of other things, like create a protocol (which I still don't understand what that is) and I eventually just gave up.

I am happy to write code and make it work, but I would need someone else to help me out with all the extra things that I don't understand like making a protocol etc.

@rickyloynd-microsoft
Copy link
Contributor

I don't know what a 'protocol' is either.

@Josephrp
Copy link
Collaborator

Josephrp commented Jul 5, 2024

would be great to work together on this @tyler-suard-parker , i have some ideas about using containers for not just new vector stores but for all new functions actually , check it out : "double PRs"? https://testcontainers.com/

@tyler-suard-parker
Copy link
Contributor Author

tyler-suard-parker commented Jul 8, 2024

@Josephrp I would be happy to work together with you on this. Let me check with my boss and see if he is OK with it. @sonichi I do not think any of us understand what a protocol is. If we write an extension for TeachableAgent that allows it to use other databases (like CosmosDB, MongoDB, etc) for storing memories, and we write the tests, can you help us out by writing (or getting someone else to help us write) whatever else is necessary to integrate it into your codebase?

@tyler-suard-parker
Copy link
Contributor Author

@Josephrp my boss said yes, let's do it!

@Josephrp
Copy link
Collaborator

Josephrp commented Jul 9, 2024

oh that's fantastic ! let's get started ... but how to coordinate ? i have a gitlab we can use actually, if you're okay with that :-)

@tyler-suard-parker
Copy link
Contributor Author

@Josephrp I just created a gitlab account, @tyler-suard-parker

@tyler-suard-parker
Copy link
Contributor Author

@Josephrp can you invite me to your project please?

@Josephrp
Copy link
Collaborator

Josephrp commented Jul 9, 2024

ha ! yeah, but let's do it on our self hosted here : https://git.tonic-ai.com

@Josephrp
Copy link
Collaborator

Josephrp commented Jul 9, 2024

@tyler-suard-parker just sign up again ;-) i'll approve you and we can get started ;-) ;-)

@tyler-suard-parker
Copy link
Contributor Author

@Josephrp Ok, I just signed up.

@Josephrp
Copy link
Collaborator

Josephrp commented Jul 9, 2024

https://git.tonic-ai.com/contribute/autogen/ great once you confirm we can start here :-)

@tyler-suard-parker
Copy link
Contributor Author

@Josephrp I am getting a 404 for that url

@Josephrp
Copy link
Collaborator

https://git.tonic-ai.com/contribute/autogen/autogen-vectorstores

@tyler-suard-parker just added you try again pls with all my appologies :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
3 participants