Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting of multi-line if fields #333

Open
DGCK81LNN opened this issue May 28, 2024 · 1 comment
Open

Highlighting of multi-line if fields #333

DGCK81LNN opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DGCK81LNN
Copy link

DGCK81LNN commented May 28, 2024

Is your feature request related to a problem? Please describe.
I often use a complex if field to enable smart skipping of the push event trigger.
image
(note that without the ${{ }} the editor yields a syntax error saying Unexpected symbol: '=='. Adding a space after the initial ! seems to eliminate the error, but I'm not sure if that works (#290).)

Writing it like that looks horrible so I format it as a multi-line string, but then the syntax highlighting is broken.
image

Describe the solution you'd like
It would be really nice to have syntax highlighting for multi-line expressions. It would look something like this:
image

@DGCK81LNN DGCK81LNN added the enhancement New feature or request label May 28, 2024
@felipesu19
Copy link
Collaborator

This would be nice. I don't know the complexity of the work, as usual, if someone makes a PR, we'd be happy to review it, but I don't think we have the capacity to spend time on it at the moment.

@felipesu19 felipesu19 added good first issue Good for newcomers help wanted Extra attention is needed labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
2 participants