-
Notifications
You must be signed in to change notification settings - Fork 58.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add instructions for increasing resources in Google Cloud #30714
Conversation
… Server instances on Google Cloud Platform
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start ⭐ Looks like there are still some placeholders in the PR, and that the PR's a draft... I've provided a little feedback that'll hopefully help you move this forward.
When this is ready for review, you can change the PR from a draft and then we'll take a look. Thanks, and let us know if you have further questions!
By the way, our team's availability is reduced over the coming couple of weeks. We'll return to this as soon as possible. Appreciate your patience in the meantime 🙏🏻
|
||
### Resizing considerations for Google Cloud Platform | ||
|
||
To add CPU or memory resources for an instance on Google Cloud, you must change the instance's size, have access to your company's Google Cloud infrastructure, and be familiar with Google Cloud Run to manage Google Cloud instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'd recommend moving this up, under the first new heading you've added.
- We want this to be a high-level overview of what the customer needs and must do. Offhand, I'll say that offhand, I don't think Google Cloud Run is involved in the launch of an instance for GHES in GCP 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattpollard! :) I picked GCP because in my research, this is what is commonly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use some help here @nguyenalex836
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Looks like work on this may still be in progress, so I'll go ahead and reopen this! Apologies on behalf of our bot 💛 |
Sorry @nguyenalex836! :) It's the holiday break, so I took some time off. I'm somewhat struggling with adding information, could you help? |
@CBID2 No problem at all! Most of our team is also enjoying the holiday break now as well 😄 Happy to help however I can - what information were you looking to add? |
### Supported Google Cloud Platform instance sizes | ||
<!-- will work on tomorrow --> | ||
|
||
### Resizing for Google Cloud Platform | ||
<!-- will work on soon --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure what to put here @nguyenalex836.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattpollard just a heads up on this comment from @CBID2! 💛
Thanks @nguyenalex836! :) I just tagged your name in the lines I need help with :) |
Thanks, @CBID2! That's actually something @mattpollard would be better suited to assist with - I see he's been working with you on this PR 💛 I'll ping him on those lines as well, so that he has visibility on this once he gets back from holiday break :) |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Reopening (apologies on behalf of the bot) |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Reopening (apologies on behalf of the bot) - @mattpollard will be giving his thoughts on this PR soon 💛 |
Internal: Talking with @mattpollard in Slack! 💛 |
Thanks @nguyenalex836! :) Let me know what you two come up with so I can add it to my PR. |
👋🏻 Thanks for your patience, @CBID2. I reviewed the plan for this, which provides a high-level overview of what you'll need to write. Could you take another look? The section for GCP should be very similar to the existing content for AWS in the article you're revising, but you'll need to adjust any AWS-specific content to reflect GCP guidance, procedures, and links out to appropriate Google docs. If you don't have access to GCP and a GHES appliance to validate the steps, I'd advise duplicating and adjusting the AWS content to start—then I can try to find someone internally who has access to GCP so that we can get a technical review of your draft. Let me know if you have questions! |
Hi @mattpollard! :) So, I don't have access to GCP, so I can duplicate the AWS content from this article? |
Yep, that should work as a starting point. You'll need to determine if there's a GCP equivalent for anything that's AWS-specific. After you have a draft, you can pull me in for initial review, and then I can coordinate technical review. |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Still working on it |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Went ahead and added |
Hey @mattpollard. You can assign this PR to someone else. |
Why:
This PR adds some tips for increasing hardware resources when using GitHub Enterprise Server instances on Google Cloud Platform. This will help GitHub customer service representatives to share information that can aid GitHub Enterprise Server administrators who use Google Cloud.
Closes:
Closes #9240
What's being changed (if available, include any code snippets, screenshots, or gifs):
12/6: Created the section for Google Cloud Platform and the headings for the subsections.
Note: I'm currently struggling with the introduction, so any advice would help.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.