Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instructions for increasing resources in Google Cloud #30714

Closed
wants to merge 6 commits into from

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Dec 17, 2023

Why:

This PR adds some tips for increasing hardware resources when using GitHub Enterprise Server instances on Google Cloud Platform. This will help GitHub customer service representatives to share information that can aid GitHub Enterprise Server administrators who use Google Cloud.

Closes:

Closes #9240

What's being changed (if available, include any code snippets, screenshots, or gifs):

12/6: Created the section for Google Cloud Platform and the headings for the subsections.
Note: I'm currently struggling with the introduction, so any advice would help.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link
Contributor

github-actions bot commented Dec 17, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/monitoring-managing-and-updating-your-instance/updating-the-virtual-machine-and-physical-resources/increasing-cpu-or-memory-resources.md ghes@ 3.12 3.11 3.10 3.9 3.8
ghes@ 3.12 3.11 3.10 3.9 3.8

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

Copy link
Contributor

@mattpollard mattpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start ⭐ Looks like there are still some placeholders in the PR, and that the PR's a draft... I've provided a little feedback that'll hopefully help you move this forward.

When this is ready for review, you can change the PR from a draft and then we'll take a look. Thanks, and let us know if you have further questions!

By the way, our team's availability is reduced over the coming couple of weeks. We'll return to this as soon as possible. Appreciate your patience in the meantime 🙏🏻


### Resizing considerations for Google Cloud Platform

To add CPU or memory resources for an instance on Google Cloud, you must change the instance's size, have access to your company's Google Cloud infrastructure, and be familiar with Google Cloud Run to manage Google Cloud instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'd recommend moving this up, under the first new heading you've added.
  • We want this to be a high-level overview of what the customer needs and must do. Offhand, I'll say that offhand, I don't think Google Cloud Run is involved in the launch of an instance for GHES in GCP 🤔
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattpollard! :) I picked GCP because in my research, this is what is commonly used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use some help here @nguyenalex836

Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 28, 2023
@github-actions github-actions bot closed this Dec 28, 2023
@nguyenalex836
Copy link
Contributor

Looks like work on this may still be in progress, so I'll go ahead and reopen this! Apologies on behalf of our bot 💛

@nguyenalex836 nguyenalex836 reopened this Dec 28, 2023
@CBID2
Copy link
Contributor Author

CBID2 commented Dec 28, 2023

Looks like work on this may still be in progress, so I'll go ahead and reopen this! Apologies on behalf of our bot 💛

Sorry @nguyenalex836! :) It's the holiday break, so I took some time off. I'm somewhat struggling with adding information, could you help?

@nguyenalex836
Copy link
Contributor

@CBID2 No problem at all! Most of our team is also enjoying the holiday break now as well 😄 Happy to help however I can - what information were you looking to add?

Comment on lines +133 to +137
### Supported Google Cloud Platform instance sizes
<!-- will work on tomorrow -->

### Resizing for Google Cloud Platform
<!-- will work on soon -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure what to put here @nguyenalex836.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattpollard just a heads up on this comment from @CBID2! 💛

@CBID2
Copy link
Contributor Author

CBID2 commented Dec 28, 2023

@CBID2 No problem at all! Most of our team is also enjoying the holiday break now as well 😄 Happy to help however I can - what information were you looking to add?

Thanks @nguyenalex836! :) I just tagged your name in the lines I need help with :)

@nguyenalex836
Copy link
Contributor

Thanks, @CBID2! That's actually something @mattpollard would be better suited to assist with - I see he's been working with you on this PR 💛

I'll ping him on those lines as well, so that he has visibility on this once he gets back from holiday break :)

@nguyenalex836 nguyenalex836 added triage Do not begin working on this issue until triaged by the team and removed stale There is no recent activity on this issue or pull request triage Do not begin working on this issue until triaged by the team labels Dec 29, 2023
Copy link
Contributor

github-actions bot commented Jan 5, 2024

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 5, 2024
@github-actions github-actions bot closed this Jan 5, 2024
@nguyenalex836
Copy link
Contributor

Reopening (apologies on behalf of the bot)

@nguyenalex836 nguyenalex836 reopened this Jan 5, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Jan 5, 2024
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 15, 2024
@github-actions github-actions bot closed this Jan 15, 2024
@nguyenalex836 nguyenalex836 reopened this Jan 16, 2024
@nguyenalex836
Copy link
Contributor

Reopening (apologies on behalf of the bot) - @mattpollard will be giving his thoughts on this PR soon 💛

@github-actions github-actions bot closed this Jan 23, 2024
@nguyenalex836 nguyenalex836 reopened this Jan 23, 2024
@nguyenalex836 nguyenalex836 removed the stale There is no recent activity on this issue or pull request label Jan 23, 2024
@nguyenalex836
Copy link
Contributor

Internal: Talking with @mattpollard in Slack! 💛

@CBID2
Copy link
Contributor Author

CBID2 commented Jan 23, 2024

Internal: Talking with @mattpollard in Slack! 💛

Thanks @nguyenalex836! :) Let me know what you two come up with so I can add it to my PR.

@mattpollard
Copy link
Contributor

mattpollard commented Jan 29, 2024

👋🏻 Thanks for your patience, @CBID2. I reviewed the plan for this, which provides a high-level overview of what you'll need to write. Could you take another look? The section for GCP should be very similar to the existing content for AWS in the article you're revising, but you'll need to adjust any AWS-specific content to reflect GCP guidance, procedures, and links out to appropriate Google docs.

If you don't have access to GCP and a GHES appliance to validate the steps, I'd advise duplicating and adjusting the AWS content to start—then I can try to find someone internally who has access to GCP so that we can get a technical review of your draft.

Let me know if you have questions!

@CBID2
Copy link
Contributor Author

CBID2 commented Jan 29, 2024

👋🏻 Thanks for your patience, @CBID2. I reviewed the plan for this, which provides a high-level overview of what you'll need to write. Could you take another look? The section for GCP should be very similar to the existing content for AWS in the article you're revising, but you'll need to adjust any AWS-specific content to reflect GCP guidance, procedures, and links out to appropriate Google docs.

If you don't have access to GCP and a GHES appliance to validate the steps, I'd advise duplicating and adjusting the AWS content to start—then I can try to find someone internally who has access to GCP so that we can get a technical review of your draft.

Let me know if you have questions!

Hi @mattpollard! :) So, I don't have access to GCP, so I can duplicate the AWS content from this article?

@mattpollard
Copy link
Contributor

mattpollard commented Jan 29, 2024

Yep, that should work as a starting point. You'll need to determine if there's a GCP equivalent for anything that's AWS-specific. After you have a draft, you can pull me in for initial review, and then I can coordinate technical review.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 6, 2024
@github-actions github-actions bot closed this Feb 6, 2024
@AhmadHusaeni

This comment was marked as off-topic.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 6, 2024

Still working on it

@mattpollard mattpollard reopened this Feb 6, 2024
@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Feb 7, 2024
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 15, 2024
@github-actions github-actions bot closed this Feb 15, 2024
@mattpollard mattpollard reopened this Feb 15, 2024
@mattpollard mattpollard removed the stale There is no recent activity on this issue or pull request label Feb 15, 2024
@nguyenalex836 nguyenalex836 added never-stale Do not close as stale and removed triage Do not begin working on this issue until triaged by the team labels Feb 15, 2024
@nguyenalex836
Copy link
Contributor

Went ahead and added never-stale to this PR

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 28, 2024

Hey @mattpollard. You can assign this PR to someone else.

@CBID2 CBID2 closed this Feb 28, 2024
@CBID2 CBID2 deleted the add-instructions-for-google-cloud branch February 28, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never-stale Do not close as stale
4 participants