-
Notifications
You must be signed in to change notification settings - Fork 58.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing Docker images page contains broken YML code #33794
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@snorremd Thank you for opening an issue! I'll get this triaged for review ✨ |
Thank you @snorremd — I suspect the linter just got overzealous at some point. You or anyone else is welcome to submit a PR with the suggested change (asterisk -> hyphen). And thank you so much for raising an issue ✨ |
The linter is still angry:
@subatoi Do I get the OP or anyone is expected to open a PR, and even with a failing CI it would get approved et al.? |
Hi @janbrasna — That's correct, provided that the error is the cause of the linter failure |
Code of Conduct
What article on docs.github.com is affected?
All articles using the
{% data reusables.actions.artifact-attestations-step-for-container-images %}
template.For example: https://github.com/github/docs/blob/main/content/actions/publishing-packages/publishing-docker-images.md
Specifically the problem is that the attestations-step-for-container-images is using an asterisk
*
instead of a dash-
in the example.Now it looks like this:
This can be confusing as one could believe the asterisk is some kind of special case.
What changes are you suggesting?
Change the https://github.com/github/docs/blob/main/data/reusables/actions/artifact-attestations-step-for-container-images.md file to use a
-
so the GitHub Actions examples using attestation step are not broken.This also requires changing the setup so the linter does not complain. See my attempts at fixing this in closed PR: #33793
Additional information
No response
The text was updated successfully, but these errors were encountered: