Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About billing and sponsorship payments #33786

Merged
merged 6 commits into from
Jul 18, 2024
Merged

About billing and sponsorship payments #33786

merged 6 commits into from
Jul 18, 2024

Conversation

Yewzir
Copy link
Contributor

@Yewzir Yewzir commented Jul 2, 2024 •
edited
Loading

Why:

Fully spontaneous, with reasoning and closes #33785. My PR renders an updated billing and payment section on GitHub Sponsors where PayPal end-of-support is explicitly mentioned, plus a bit of free advertising for GitHub products that are actually still supported, I think. I'm not an employee so if one of the products isn't supported or has never been supported by PayPal funding, I'm happy to hear and I will perform the respective modifications in turn. I can't think of a better place to sneak that in while it's still actually relevant information.

Not to worry, I will not propose being able to set you up with the translation in the Dutch language. Well, I could but I won't. Just because I noticed translation a lot in the guidelines and stylings, I gave it a spin on GT and I'm definitely amazed at how accurate the translation it generates is.

I think it's a decent looking, non disturbing block and a smooth read. Translations, those are the least of my worries. So, here goes.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Free, Pro & Team Editions

image

Enterprise Cloud & Server Editions

image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.
@welcome Welcome
Copy link

welcome bot commented Jul 2, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 2, 2024
@Yewzir Yewzir marked this pull request as draft July 2, 2024 01:23
@Yewzir Yewzir marked this pull request as ready for review July 2, 2024 01:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
sponsors/sponsoring-open-source-contributors/about-sponsorships-fees-and-taxes.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@Yewzir Yewzir marked this pull request as draft July 2, 2024 02:16
@Yewzir Yewzir marked this pull request as ready for review July 2, 2024 02:46
@Yewzir Yewzir marked this pull request as draft July 2, 2024 03:03
@Yewzir Yewzir marked this pull request as ready for review July 2, 2024 03:06
Yewzir
Yewzir commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@Yewzir Yewzir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost finished, I swear.
Yewzir
Yewzir commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@Yewzir Yewzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reflects all changes leading to the images in the PR description for the different editions.
@nguyenalex836
Copy link
Contributor

@Yewzir Thanks so much for opening a PR! I'll get this triaged for review ✨
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review sponsors Content related to GitHub Sponsors and removed triage Do not begin working on this issue until triaged by the team labels Jul 2, 2024
@nguyenalex836 nguyenalex836 added needs SME This proposal needs review from a subject matter expert and removed waiting for review Issue/PR is waiting for a writer's review labels Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀
andimiya
andimiya reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@andimiya andimiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo/grammar suggestion but looks good, thank you!
Yewzir and others added 2 commits July 18, 2024 23:12
@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Jul 18, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Jul 18, 2024
@nguyenalex836
Copy link
Contributor

@Yewzir Thank you for updating your PR with the suggestions @andimiya provided! I'll get this merged 🍏
@Yewzir
Copy link
Contributor Author

Yewzir commented Jul 18, 2024

@Yewzir Thank you for updating your PR with the suggestions @andimiya provided! I'll get this merged 🍏

Nice, thank you!
Merged via the queue into github:main with commit 3ccfc87 Jul 18, 2024
54 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡
@Yewzir Yewzir deleted the make-docs branch July 18, 2024 21:32
Deus398 added a commit to Deus398/docs that referenced this pull request Jul 18, 2024
@Deus398
Revert "About billing and sponsorship payments (github#33786)"
3def0b8 
This reverts commit 3ccfc87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR sponsors Content related to GitHub Sponsors
3 participants
@Yewzir @nguyenalex836 @andimiya