Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No doc of on.merge_group.<branches|branches-ignore> #32879

Open
1 task done
muzimuzhi opened this issue May 8, 2024 · 4 comments
Open
1 task done

No doc of on.merge_group.<branches|branches-ignore> #32879

muzimuzhi opened this issue May 8, 2024 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review

Comments

@muzimuzhi
Copy link
Contributor

muzimuzhi commented May 8, 2024 •
edited
Loading

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions

What part(s) of the article would you like to see updated?

GitHub Actions merge_group trigger supports branches filter since its beta release in Aug 2022, but it's not documented till now.

I guess the symmetric branches-ignore filter is also supported but didn't check it myself.

One option is to extend current section on.<pull_request|pull_request_target>.<branches|branches-ignore> to cover merge_group and taking care of old anchor name redirection. Or add a separate on.merge_group.<branches|branches-ignore> section.

Additional information

Relevant GitHub Blogs

Related
@muzimuzhi muzimuzhi added the content This issue or pull request belongs to the Docs Content team label May 8, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 8, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 8, 2024
@nguyenalex836
Copy link
Contributor

@muzimuzhi Thank you for opening this issue! I'll get this triaged for review ✨
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jul 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@muzimuzhi
Copy link
Contributor Author

Sorry but I don't think this has been resolved.
@nguyenalex836
Copy link
Contributor

@muzimuzhi Apologies on behalf of our overzealous bot! I'll reopen this 💛
@nguyenalex836 nguyenalex836 reopened this Jul 17, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 17, 2024
@nguyenalex836 nguyenalex836 removed triage Do not begin working on this issue until triaged by the team stale There is no recent activity on this issue or pull request labels Jul 18, 2024
@SiaraMist SiaraMist added the needs SME This proposal needs review from a subject matter expert label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
4 participants
@muzimuzhi @SiaraMist @nguyenalex836 and others