Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update about-code-owners.md #33396

Closed
wants to merge 1 commit into from
Closed

Update about-code-owners.md #33396

wants to merge 1 commit into from

Conversation

SjxSubham
Copy link

Why: Regarding issue #32812 , there should be a information in the CODEOWNERS Syntax docs that team name in '.' (non-allowed charecters) format is not allowed. So, I have added that info

Closes: #32812

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team code owners Content related to code owners and removed triage Do not begin working on this issue until triaged by the team labels Jun 7, 2024
@nguyenalex836
Copy link
Contributor

nguyenalex836 commented Jun 7, 2024 •
edited
Loading

@SjxSubham Thank you for opening a PR! #32812 is still waiting for a review from our team, so we will need to put this PR on hold until that issue is reviewed 💛 thank you for your patience, and willingness to contribute!
@github-actions GitHub Actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jun 21, 2024
@github-actions github-actions bot closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code owners Content related to code owners content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request
2 participants
@SjxSubham @nguyenalex836