Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github actions): steps context not listed in job environment url #32603

Closed
1 task done
johnnygerard opened this issue Apr 20, 2024 · 2 comments · Fixed by #33966
Closed
1 task done

docs(github actions): steps context not listed in job environment url #32603

johnnygerard opened this issue Apr 20, 2024 · 2 comments · Fixed by #33966
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue

Comments

@johnnygerard
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

Under jobs.<job_id>.environment, it says:

The value of url can be an expression. Allowed expression contexts: github, inputs, vars, needs, strategy, matrix, job, runner, and env.

The steps context is not listed despite being used in the example below:

environment:
  name: production_environment
  url: ${{ steps.step_id.outputs.url_output }}

What changes are you suggesting?

Add steps to the list of allowed expression contexts.

Additional information

No response

@johnnygerard johnnygerard added the content This issue or pull request belongs to the Docs Content team label Apr 20, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 20, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 22, 2024
@nguyenalex836
Copy link
Contributor

@johnnygerard Thank you for opening this issue! I'll get this triaged for review ✨

@SiaraMist
Copy link
Contributor

Thank you for opening this issue @johnnygerard! ✨ This update to the docs makes sense to me. You are anyone else is free to open a pull request to make these changes.

@SiaraMist SiaraMist added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue
3 participants