-
Notifications
You must be signed in to change notification settings - Fork 58.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent usages of ACTIONS_ID_TOKEN_REQUEST_TOKEN
and ACTIONS_RUNTIME_TOKEN
#32573
Comments
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@jiasli Thank you for opening this issue! I'll get this triaged for review ✨ |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this issue is waiting for technical review. |
This comment is not based on hard science - I'd like @github/actions-runtime opinion on this to be sure. |
Thanks for chiming in with this info, @lucavallin. Based on this, I think it's okay for us to update this. Since this article is restricted by a CODEOWNERS file, we will transfer this internally and work on this fix. |
Thank you for opening this issue! Updates to this documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue. |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers
What part(s) of the article would you like to see updated?
First it says using environment variable
ACTIONS_ID_TOKEN_REQUEST_TOKEN
:https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers#adding-permissions-settings
Later on, it says using
ACTIONS_RUNTIME_TOKEN
:https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-cloud-providers#using-custom-actions
I checked in an actual run and saw they contain the same value, but the document should be consistent on which environment variable should be used.
Additional information
No response
The text was updated successfully, but these errors were encountered: