fixed: The savegame's PNG loader must use a caching FileReader to avo…

…id holding a handle to the containing file. This blocked savegame deletion.
ZDoom · May 1, 2024 · f2d582f · f2d582f
1 parent 81dade9
commit f2d582f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/common/menu/savegamemanager.cpp b/src/common/menu/savegamemanager.cpp
@@ -316,7 +316,8 @@ unsigned FSavegameManagerBase::ExtractSaveData(int index)
 		auto pic = resf->FindEntry("savepic.png");
 		if (pic >= 0)
 		{
-			FileReader picreader = resf->GetEntryReader(pic, FileSys::READER_NEW, FileSys::READERFLAG_SEEKABLE);
+			// This must use READER_CACHED or it will lock the savegame file.
+			FileReader picreader = resf->GetEntryReader(pic, FileSys::READER_CACHED, FileSys::READERFLAG_SEEKABLE);
 			PNGHandle *png = M_VerifyPNG(picreader);
 			if (png != nullptr)
 			{